-
-
Notifications
You must be signed in to change notification settings - Fork 681
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add new category to categorylist.js #2197
feat: add new category to categorylist.js #2197
Conversation
✅ Deploy Preview for asyncapi-website ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deploy-preview-2197--asyncapi-website.netlify.app/ |
Co-authored-by: Lukasz Gornicki <[email protected]>
Co-authored-by: Lukasz Gornicki <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@TheEques almost there, asyncapi-asciidoc-template that is already listed in tools, please add to this new category too
that I wrote in the other PR is still needed
@akshatnema is it all that has to be done to add a new category? maybe we should have a new section in https://github.com/asyncapi/community/blob/master/new-tool-documentation.md
@derberg like change it from Documentation Generators to AsyncAPI Generator templates? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@TheEques no, just add one category more, so it is under templates too
Yeah, there should be sections on how to add new category and new tags inside tools. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved ✔️ , but wait for @derberg's review.
@akshatnema what about the manual file, wasn't your idea to always add "empty" object there for new category, so it is easier for others to add? |
btw, followup issue for docs so we do not forget asyncapi/community#899 |
Hey @derberg, @akshatnema, do I have to make changes in manual file? |
Yepp, we have to add an empty object in tools-manual.json. @derberg Thanks for reminding me. |
Adding |
…Eques/website into Asyncapi-generator-templates
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested on the local ✔️
Any more points from your side? @derberg |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
awesome 🚀
@TheEques thanks a hundred. Hope you are open to add .asyncapi-tools
to the rest of the templates 😃
/rtm |
Yes indeed 👍 |
Hi, @derberg, @akshatnema should I wait till tomorrow to see if the changes made are reflected properly and then start adding other templates or should I just go ahead and add |
it is already refreshed on the website @akshatnema asciidoc template is not under |
@derberg so should I make changes in the |
you can test if I'm right that this is the reason why it is not there |
Added new category to categorylist.js
Resolves Issue #2180