Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add new category to categorylist.js #2197

Merged
merged 9 commits into from
Oct 7, 2023

Conversation

TheEques
Copy link
Contributor

@TheEques TheEques commented Oct 3, 2023

Added new category to categorylist.js
Resolves Issue #2180

@netlify
Copy link

netlify bot commented Oct 3, 2023

Deploy Preview for asyncapi-website ready!

Name Link
🔨 Latest commit 5736678
🔍 Latest deploy log https://app.netlify.com/sites/asyncapi-website/deploys/6521d23934a04f000810ce29
😎 Deploy Preview https://deploy-preview-2197--asyncapi-website.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions
Copy link

github-actions bot commented Oct 3, 2023

⚡️ Lighthouse report for the changes in this PR:

Category Score
🔴 Performance 19
🟢 Accessibility 98
🟢 Best practices 100
🟢 SEO 100
🔴 PWA 30

Lighthouse ran on https://deploy-preview-2197--asyncapi-website.netlify.app/

scripts/tools/categorylist.js Outdated Show resolved Hide resolved
scripts/tools/categorylist.js Outdated Show resolved Hide resolved
@derberg derberg changed the title feat: added new category to categorylist.js feat: add new category to categorylist.js Oct 3, 2023
TheEques and others added 2 commits October 3, 2023 19:10
Copy link
Member

@derberg derberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TheEques almost there, asyncapi-asciidoc-template that is already listed in tools, please add to this new category too that I wrote in the other PR is still needed

@akshatnema is it all that has to be done to add a new category? maybe we should have a new section in https://github.com/asyncapi/community/blob/master/new-tool-documentation.md

@TheEques
Copy link
Contributor Author

TheEques commented Oct 3, 2023

@derberg like change it from Documentation Generators to AsyncAPI Generator templates?

Copy link
Member

@derberg derberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TheEques no, just add one category more, so it is under templates too

@akshatnema
Copy link
Member

@akshatnema is it all that has to be done to add a new category? maybe we should have a new section in asyncapi/community@master/new-tool-documentation.md

Yeah, there should be sections on how to add new category and new tags inside tools.

akshatnema
akshatnema previously approved these changes Oct 3, 2023
Copy link
Member

@akshatnema akshatnema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved ✔️ , but wait for @derberg's review.

@akshatnema akshatnema added the hacktoberfest-accepted PRs which are accepted under Hacktoberfest label Oct 3, 2023
@derberg
Copy link
Member

derberg commented Oct 4, 2023

@akshatnema what about the manual file, wasn't your idea to always add "empty" object there for new category, so it is easier for others to add?

@derberg
Copy link
Member

derberg commented Oct 4, 2023

btw, followup issue for docs so we do not forget asyncapi/community#899

@TheEques
Copy link
Contributor Author

TheEques commented Oct 5, 2023

Hey @derberg, @akshatnema, do I have to make changes in manual file?

@akshatnema
Copy link
Member

@akshatnema what about the manual file, wasn't your idea to always add "empty" object there for new category, so it is easier for others to add?

Yepp, we have to add an empty object in tools-manual.json. @derberg Thanks for reminding me.
@TheEques Kindly add the new category in manual tools file, with empty list in ToolsList.

@akshatnema
Copy link
Member

Adding do-not-merge so that proper changes are added inside the PR.

Copy link
Member

@akshatnema akshatnema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on the local ✔️

@akshatnema
Copy link
Member

Any more points from your side? @derberg

Copy link
Member

@derberg derberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome 🚀

@TheEques thanks a hundred. Hope you are open to add .asyncapi-tools to the rest of the templates 😃

@derberg
Copy link
Member

derberg commented Oct 7, 2023

/rtm

@asyncapi-bot asyncapi-bot merged commit c2ef935 into asyncapi:master Oct 7, 2023
11 checks passed
@TheEques
Copy link
Contributor Author

TheEques commented Oct 8, 2023

awesome 🚀

@TheEques thanks a hundred. Hope you are open to add .asyncapi-tools to the rest of the templates 😃

Yes indeed 👍

@TheEques
Copy link
Contributor Author

TheEques commented Oct 8, 2023

Hi, @derberg, @akshatnema should I wait till tomorrow to see if the changes made are reflected properly and then start adding other templates or should I just go ahead and add asyncapi.tool files to the tool repositories?

Copy link
Member

derberg commented Oct 9, 2023

it is already refreshed on the website

@akshatnema asciidoc template is not under generator-template category, I guess it is because it is not enough to add category for manual-added-tool, you actually need to duplicate the entry under each category?

@TheEques
Copy link
Contributor Author

TheEques commented Oct 9, 2023

@derberg so should I make changes in the tools-manual file?

Copy link
Member

derberg commented Oct 10, 2023

you can test if I'm right that this is the reason why it is not there

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest-accepted PRs which are accepted under Hacktoberfest ready-to-merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a new category to https://www.asyncapi.com/tools for AsyncAPI Generator templates
4 participants