Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: disable google analytics if domain not asyncapi.com #2177

Merged
merged 1 commit into from
Sep 28, 2023

Conversation

yuvrxj-afk
Copy link
Contributor

Description

  • Disabled google analytics on previews
  • Simple check condition for asyncapi.com

Related issue(s) Fixes #2156

@netlify
Copy link

netlify bot commented Sep 28, 2023

Deploy Preview for asyncapi-website ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 6dfe544
🔍 Latest deploy log https://app.netlify.com/sites/asyncapi-website/deploys/651525453bdd9600087f8629
😎 Deploy Preview https://deploy-preview-2177--asyncapi-website.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions
Copy link

⚡️ Lighthouse report for the changes in this PR:

Category Score
🔴 Performance 25
🟢 Accessibility 98
🟢 Best practices 100
🟢 SEO 100
🔴 PWA 30

Lighthouse ran on https://deploy-preview-2177--asyncapi-website.netlify.app/

@derberg derberg changed the title chore: disable - ga from the website fix: disable google analytics if domain not asyncapi.com Sep 28, 2023
Copy link
Member

@derberg derberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!!! I only adjusted the title a bit to have more descriptive commit

@derberg
Copy link
Member

derberg commented Sep 28, 2023

/rtm

@asyncapi-bot asyncapi-bot merged commit 9471b83 into asyncapi:master Sep 28, 2023
23 checks passed
@derberg
Copy link
Member

derberg commented Sep 28, 2023

@allcontributors please add @yuvrxj-afk for code

@allcontributors
Copy link
Contributor

@derberg

I've put up a pull request to add @yuvrxj-afk! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

disable google analytics on previews and localhost
3 participants