Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update twitter logo with X icon and responsive #2167

Merged
merged 2 commits into from
Sep 26, 2023

Conversation

captain-Akshay
Copy link
Contributor

@captain-Akshay captain-Akshay commented Sep 25, 2023

Description

  • Updated the Twitter Logo from bird to X
  • Made sure that it's responsive on all the devices

Result

image

Test result :-

image

Related issue(s)
Issue related : #2165

@netlify
Copy link

netlify bot commented Sep 25, 2023

Deploy Preview for asyncapi-website ready!

Name Link
🔨 Latest commit 5f1c294
🔍 Latest deploy log https://app.netlify.com/sites/asyncapi-website/deploys/65128c258a92350008ed4e64
😎 Deploy Preview https://deploy-preview-2167--asyncapi-website.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.

@github-actions
Copy link

github-actions bot commented Sep 25, 2023

⚡️ Lighthouse report for the changes in this PR:

Category Score
🔴 Performance 23
🟢 Accessibility 98
🟢 Best practices 100
🟢 SEO 100
🔴 PWA 30

Lighthouse ran on https://deploy-preview-2167--asyncapi-website.netlify.app/

Copy link
Member

@derberg derberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@derberg derberg changed the title refactor: update twitter logo with X icon and responsive feat: update twitter logo with X icon and responsive Sep 26, 2023
@derberg
Copy link
Member

derberg commented Sep 26, 2023

/rtm

@asyncapi-bot asyncapi-bot merged commit a29437a into asyncapi:master Sep 26, 2023
14 checks passed
@derberg
Copy link
Member

derberg commented Sep 26, 2023

@allcontributors please add @captain-Akshay for code

@allcontributors
Copy link
Contributor

@derberg

I've put up a pull request to add @captain-Akshay! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants