feat: add features list translations #2074
Conversation
Signed-off-by: Ansh Goyal <[email protected]>
anshgoyalevil
requested review from
derberg,
akshatnema,
magicmatatjahu,
Mayaleeeee and
asyncapi-bot-eve
as code owners
✅ Deploy Preview for asyncapi-website ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
anshgoyalevil
changed the title
|
//cc @magicmatatjahu 🚀 |
anshgoyalevil
changed the title
|
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deploy-preview-2074--asyncapi-website.netlify.app/ |
| @@ -1,50 +1,56 @@ | |||
| export const features = [ | |||
There was a problem hiding this comment.
Do we need that file when we have this content inside locales? Except that question, everything is good :)
There was a problem hiding this comment.
Yes. Actually we are using the ids of those features to create unique translation keys to fetch those from the locales. It would also act like a first source of truth, and cypress testing, since parsing from the json would not be convenient in cypress tests
There was a problem hiding this comment.
Like here for example
{t(`features.${feature.id}.name`)}There was a problem hiding this comment.
So maybe put another texts as values to keys, not whole content, ok?
There was a problem hiding this comment.
Didn't get that. Please clarify. Do you mean creating another array of keys inside the file itself rather than importing features.js and using it for keys?
There was a problem hiding this comment.
I see what you did :) Only remove not needed keys from /features map, like description etc, only leave id, label, href etc, what you exactly used.
There was a problem hiding this comment.
Done with the changes 🚀
Signed-off-by: Ansh Goyal <[email protected]>
|
/rtm |
Description
This PR adds the translations for the homepage's features section.
Related issue(s)
part of #2039