feat: add homepage translations for asyncapi website #2040
Conversation
Signed-off-by: Ansh Goyal <[email protected]>
anshgoyalevil
requested review from
derberg,
akshatnema,
magicmatatjahu,
Mayaleeeee and
asyncapi-bot-eve
as code owners
✅ Deploy Preview for asyncapi-website ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
//cc @magicmatatjahu 🚀 |
Signed-off-by: Ansh Goyal <[email protected]>
|
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deploy-preview-2040--asyncapi-website.netlify.app/ |
|
@anshgoyalevil Try to also translate the buttons like here
and also another section like |
|
Sure. Missed out on that 🚀 |
Signed-off-by: Ansh Goyal <[email protected]>
|
@magicmatatjahu Done with the changes 🚀 Please check |
Signed-off-by: Ansh Goyal <[email protected]>
|
And last one 😄
|
|
@magicmatatjahu I tried translating this section but we are importing the data for it from json file, and mapping it thereafter to the next components, so it is not getting translated. Should I transfer the content of that json to an array inside the file where it is being consumed? 🤔 |
|
@anshgoyalevil Yes, move that to the i18n files :) |
|
I can accept that PR and you can do that in next PRs, ok? :) Merging. |
|
Okay. Thanks 😄 |
|
/rtm |
Description
Germanlanguage..gitignorefile is modified to ignore the generated screenshots and videos while using the commandnpx cypress run --componentRelated issue(s)
fixes partly #2039
How to test
Live changes can be viewed by appending
enordeto the netlify URL for this PR. For example{netlifyURL}/de