Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: added "adding channel" page #1958

Closed
wants to merge 8 commits into from

Conversation

mhmohona
Copy link
Contributor

@mhmohona mhmohona commented Jul 17, 2023

Description
Added Adding channel page.

It is a part of GSoD'23 project.

Related issue(s): fixes #1510

@netlify
Copy link

netlify bot commented Jul 17, 2023

Deploy Preview for shimmering-choux-eb0798 ready!

Name Link
🔨 Latest commit 4f867ca
🔍 Latest deploy log https://app.netlify.com/sites/shimmering-choux-eb0798/deploys/64f6a5025cb9c3000826d498
😎 Deploy Preview https://deploy-preview-1958--shimmering-choux-eb0798.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@mhmohona mhmohona changed the title Adding channel docs: added "adding channel" page Jul 17, 2023
Copy link
Member

@quetzalliwrites quetzalliwrites left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

here you go, feedback to help you start your next draft ✨✨✨

@quetzalliwrites quetzalliwrites added 📑 docs area/docs Specify what technical area given issue relates to. Its goal is to ease filtering good first issues. gsod This label should be used for issues or discussions related to ideas for Google Season of Docs labels Jul 20, 2023
@mhmohona mhmohona requested a review from quetzalliwrites July 24, 2023 10:06
@mhmohona
Copy link
Contributor Author

@smoya, Can you please have a look at it and give your review?
Thank you!

Copy link
Member

@quetzalliwrites quetzalliwrites left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's focus on getting a detailed technical review for this PR too now ✌🏽

@derberg derberg deleted the branch asyncapi:next-major-spec December 5, 2023 09:40
@derberg derberg closed this Dec 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/docs Specify what technical area given issue relates to. Its goal is to ease filtering good first issues. 📑 docs gsod This label should be used for issues or discussions related to ideas for Google Season of Docs
Projects
Status: Community PR under Review 🧐
Development

Successfully merging this pull request may close these issues.

3 participants