Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: release v3 #1851

Merged
merged 38 commits into from
Dec 5, 2023
Merged

chore: release v3 #1851

merged 38 commits into from
Dec 5, 2023

Conversation

jonaslagoni
Copy link
Member

@jonaslagoni jonaslagoni commented Jun 28, 2023

@netlify
Copy link

netlify bot commented Jun 28, 2023

Deploy Preview for asyncapi-website ready!

Name Link
🔨 Latest commit 1ced103
🔍 Latest deploy log https://app.netlify.com/sites/asyncapi-website/deploys/656eefba31900700081c41dc
😎 Deploy Preview https://deploy-preview-1851--asyncapi-website.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@derberg
Copy link
Member

derberg commented Jun 28, 2023

@jonaslagoni please add somewhere to your task list #1866 as a must have merge before this PR is merged 🙏🏼

@jonaslagoni
Copy link
Member Author

I also added the following tasks as being required before merge:

Feel free to add more :)

Co-authored-by: Alejandra Quetzalli <[email protected]>%0ACo-authored-by: Alejandra Quetzalli <[email protected]>
@netlify
Copy link

netlify bot commented Jun 29, 2023

Deploy Preview for shimmering-choux-eb0798 ready!

Name Link
🔨 Latest commit 3803490
🔍 Latest deploy log https://app.netlify.com/sites/shimmering-choux-eb0798/deploys/656a8caf8b28cd0008f67649
😎 Deploy Preview https://deploy-preview-1851--shimmering-choux-eb0798.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@jonaslagoni
Copy link
Member Author

/au

@akshatnema
Copy link
Member

Ohh man!!, this PR is not getting auto-updated with the master branch. I'm doing it manually this time.
cc: @derberg

@derberg
Copy link
Member

derberg commented Sep 12, 2023

maybe there are issues with autoupdate because it is draft?

@derberg
Copy link
Member

derberg commented Sep 12, 2023

Screenshot 2023-09-12 at 21 16 16

@akshatnema
Copy link
Member

I think we should remove that check now? Since, contributors do need to update the PR if it is not ready for review.

Also, I'm not able to update the PR manually. It's giving errors.

@jonaslagoni
Copy link
Member Author

The easiest is probably just to mark the PR as review for review and you folks ignore it :D

Copy link
Member

derberg commented Sep 13, 2023

I think we should remove that check now? Since, contributors do need to update the PR if it is not ready for review.

that is a global change for all, I'm not sure we want to do it

if there are exceptions from this rule, just make this pr "ready" and then update and make draft again if you want. Or just make it ready with label do-not-merge

@asyncapi-bot
Copy link
Contributor

asyncapi-bot commented Dec 4, 2023

⚡️ Lighthouse report for the changes in this PR:

Category Score
🔴 Performance 36
🟢 Accessibility 98
🟢 Best practices 92
🟢 SEO 100
🔴 PWA 33

Lighthouse ran on https://deploy-preview-1851--asyncapi-website.netlify.app/

@smoya
Copy link
Member

smoya commented Dec 4, 2023

Because of this issue, we need to manually merge this PR if we want to keep mentions to the co-authors of this PR.

So please, when merging, add the following commit message description literally (with the two empty lines at the beginning as well):



Co-authored-by: Rohit <[email protected]>
Co-authored-by: Al Amin Muhammad <[email protected]>
Co-authored-by: Afzal Ansari <[email protected]>
Co-authored-by: Alejandra Quetzalli <[email protected]>
Co-authored-by: Fran Méndez <[email protected]>
Co-authored-by: Animesh Kumar <[email protected]>
Co-authored-by: Lukasz Gornicki <[email protected]>
Co-authored-by: Mahfuza Humayra Mohona <[email protected]>

derberg
derberg previously approved these changes Dec 4, 2023
derberg
derberg previously approved these changes Dec 5, 2023
@derberg derberg merged commit 7417a7b into master Dec 5, 2023
16 of 19 checks passed
@derberg derberg deleted the next-major-spec branch December 5, 2023 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.