Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add back/prev button in generator documentation #1178

Closed
wants to merge 1 commit into from

Conversation

Ankitchaudharyy
Copy link
Contributor

Description
Added previous and next buttons in generator documentation.

Related issue(s)
#1176

@netlify
Copy link

netlify bot commented Dec 21, 2022

Deploy Preview for asyncapi-website ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit d75b344
🔍 Latest deploy log https://app.netlify.com/sites/asyncapi-website/deploys/63a2bbe4987c0f000807311b
😎 Deploy Preview https://deploy-preview-1178--asyncapi-website.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions
Copy link

⚡️ Lighthouse report for the changes in this PR:

Category Score
🔴 Performance 44
🟠 Accessibility 88
🟢 Best practices 100
🟢 SEO 100
🔴 PWA 30

Lighthouse ran on https://deploy-preview-1178--asyncapi-website.netlify.app/

@derberg
Copy link
Member

derberg commented Dec 21, 2022

@Ankitchaudharyy thanks but I have to close this PR. In the website repo we only keep copy of generator docs. These are copied on every change from https://github.com/asyncapi/generator/tree/master/docs. So basically all the work you just did would be overridden anyway in next change to generator docs.

Please do not yet create PR for the generator. Maybe you want to contribute #1000 ?

@derberg derberg closed this Dec 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants