Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: removed flickering effect in navbar for small devices #3014

Merged
merged 2 commits into from
Jul 6, 2024

Conversation

anuragnegi000
Copy link
Contributor

Description

The navbar is now opening smoothly without causing any visual flicker to the logo or other elements.

Before:-

Flicker.mp4

After:-

After.mp4

Related issue(s)
#3013

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.

Copy link

netlify bot commented May 31, 2024

Deploy Preview for asyncapi-website ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 75b98d5
🔍 Latest deploy log https://app.netlify.com/sites/asyncapi-website/deploys/6689641a8644f200084a2964
😎 Deploy Preview https://deploy-preview-3014--asyncapi-website.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@asyncapi-bot
Copy link
Contributor

asyncapi-bot commented May 31, 2024

⚡️ Lighthouse report for the changes in this PR:

Category Score
🔴 Performance 37
🟢 Accessibility 98
🟢 Best practices 92
🟢 SEO 100
🟠 PWA 56

Lighthouse ran on https://deploy-preview-3014--asyncapi-website.netlify.app/

Copy link
Member

@sambhavgupta0705 sambhavgupta0705 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@anuragnegi000 anuragnegi000 changed the title fix: Removed flickering effect in navbar for small devices fix: removed flickering effect in navbar for small devices Jun 12, 2024
@anuragnegi000
Copy link
Contributor Author

@derberg Please look into this

@anuragnegi000
Copy link
Contributor Author

@sambhavgupta0705 Please re-check this, as one test case was failing before so it's refreshed again

@anuragnegi000
Copy link
Contributor Author

@akshatnema @anshgoyalevil please check this PR

Copy link
Collaborator

@TRohit20 TRohit20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, TAL & merge @anshgoyalevil @akshatnema

Copy link
Member

@anshgoyalevil anshgoyalevil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @anuragnegi000 🚢

@anshgoyalevil
Copy link
Member

/rtm

@asyncapi-bot asyncapi-bot merged commit 98d3029 into asyncapi:master Jul 6, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants