fix: v3 specification reference section not loading during dev mode #3004
Conversation
jerensl
requested review from
derberg,
akshatnema,
magicmatatjahu,
anshgoyalevil,
Mayaleeeee and
asyncapi-bot-eve
as code owners
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.
✅ Deploy Preview for asyncapi-website ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deploy-preview-3004--asyncapi-website.netlify.app/ |
components/layout/DocsLayout.tsx
Outdated
| @@ -191,7 +191,7 @@ export default function DocsLayout({ post, navItems = {}, children }: IDocsLayou | |||
| </span> | |||
| <span className='font-sans text-sm text-gray-800 antialiased'> | |||
| Check | |||
| <Link href='https://www.asyncapi.com/blog?tags=Release+Notes'> | |||
| <Link href='https://www.asyncapi.com/blog?tags=Release+Notes' passHref legacyBehavior> | |||
There was a problem hiding this comment.
Why don't we remove the a tag inside the Link and use the new Link Component only?
There was a problem hiding this comment.
I thought TailwindCSS would not work but after carefully double-checking it's working fine. The latest commit should remove the a tag and put the behavior and style to the new next/link component
|
/rtm |
Description
These breaking changes are part of NextJS 13. If the Link Components have a tag it should wrap passHref and should put legacyBehavior. Another alternative is to use codemods.
Related issue(s)
Fixes #3002