Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: v3 specification reference section not loading during dev mode #3004

Merged
merged 4 commits into from
May 31, 2024
Merged

fix: v3 specification reference section not loading during dev mode #3004

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
89f6b11
fix: v3 specification reference section not loading during developmen…
jerensl May 30, 2024
b13afef
fix: fix the linter problem
jerensl May 30, 2024
70a6890
fix: remove child tag and put the behavior and style to next/link
jerensl May 30, 2024
56ca6b3
Merge branch 'master' into fix/s3-specs-not-loading
akshatnema May 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions components/layout/DocsLayout.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -172,7 +172,7 @@ export default function DocsLayout({ post, navItems = {}, children }: IDocsLayou
<span className='font-sans text-sm text-gray-800 antialiased'>
{`What is new in v${post.title}? Have a look at the `}
</span>
<Link href={post.releaseNoteLink}>
<Link href={post.releaseNoteLink} passHref legacyBehavior>
<a
target='_blank'
rel='noopener noreferrer'
Expand All @@ -191,7 +191,7 @@ export default function DocsLayout({ post, navItems = {}, children }: IDocsLayou
</span>
<span className='font-sans text-sm text-gray-800 antialiased'>
Check&nbsp;
<Link href='https://www.asyncapi.com/blog?tags=Release+Notes'>
<Link href='https://www.asyncapi.com/blog?tags=Release+Notes' passHref legacyBehavior>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why don't we remove the a tag inside the Link and use the new Link Component only?

Copy link
Contributor Author

@jerensl jerensl May 30, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought TailwindCSS would not work but after carefully double-checking it's working fine. The latest commit should remove the a tag and put the behavior and style to the new next/link component

<a
target='_blank'
rel='noopener noreferrer'
Expand Down
Loading