refactor: update type definitions for discussions and improve null ha…

…ndling
asyncapi · Dec 30, 2024 · e974218 · e974218
1 parent a220216
commit e974218
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 9 deletions.
diff --git a/scripts/dashboard/build-dashboard.ts b/scripts/dashboard/build-dashboard.ts
@@ -43,10 +43,10 @@ function getLabel(issue: GoodFirstIssues, filter: string) {
 async function getDiscussions(
   query: string,
   pageSize: number,
-  endCursor = null
-): Promise<Discussion['data']['search']['nodes']> {
+  endCursor: null | string = null
+): Promise<Discussion['search']['nodes']> {
   try {
-    const result: any = await graphql(query, {
+    const result: Discussion = await graphql(query, {
       first: pageSize,
       after: endCursor,
       headers: {

diff --git a/types/scripts/dashboard.ts b/types/scripts/dashboard.ts
@@ -7,7 +7,7 @@ interface RateLimit {
 
 interface PageInfo {
   hasNextPage: boolean;
-  endCursor?: string;
+  endCursor: string | null;
 }
 
 interface Reactions {
@@ -138,11 +138,9 @@ export interface HotDiscussionsPullRequestsNode {
   comments: Comments;
 }
 export interface Discussion {
-  data: {
-    search: {
-      pageInfo: PageInfo;
-      nodes: HotDiscussionsPullRequestsNode[] | HotDiscussionsIssuesNode[] | GoodFirstIssues[];
-    };
+  search: {
+    pageInfo: PageInfo;
+    nodes: HotDiscussionsPullRequestsNode[];
   };
   rateLimit: RateLimit;
 }