Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add artur-ciocanu as scala champion #1686

Merged
merged 3 commits into from
Dec 31, 2023
Merged

Conversation

jonaslagoni
Copy link
Member

@jonaslagoni jonaslagoni commented Dec 23, 2023

With the newly added Scala generator (#1665), @artur-ciocanu wanted to remain as champion for it 💪🔥

cc @kennethaasan @magicmatatjahu @Ferror @leigh-johnson @Samridhi-98 @devilkiller-ag any objections?

Lazy consensus will be used with @artur-ciocanu acceptance after 1 week from this PR creation 🙂

Copy link

netlify bot commented Dec 23, 2023

Deploy Preview for modelina canceled.

Name Link
🔨 Latest commit 7009447
🔍 Latest deploy log https://app.netlify.com/sites/modelina/deploys/6590b3d747713e0008b51fa2

@jonaslagoni
Copy link
Member Author

@artur-ciocanu just for a good measure, do you mind also giving you approval ✌️

@coveralls
Copy link

coveralls commented Dec 23, 2023

Pull Request Test Coverage Report for Build 7367180032

Warning: This coverage report may be inaccurate.

We've detected an issue with your CI configuration that might affect the accuracy of this pull request's coverage report.
To ensure accuracy in future PRs, please see these guidelines.
A quick fix for this PR: rebase it; your next report should be accurate.

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 92.33%

Totals Coverage Status
Change from base Build 7360968764: 0.0%
Covered Lines: 5867
Relevant Lines: 6193

💛 - Coveralls

@devilkiller-ag
Copy link
Member

Welcome @artur-ciocanu

@artur-ciocanu
Copy link
Collaborator

artur-ciocanu commented Dec 23, 2023

@artur-ciocanu just for a good measure, do you mind also giving you approval ✌️

Hey @jonaslagoni I approve, not sure if anything more formal is required. Just let me know.

@jonaslagoni
Copy link
Member Author

@artur-ciocanu by reviewing the PR (see files changed) you should be able to approve it, but verbal is fine as well 😄👌

Copy link
Collaborator

@artur-ciocanu artur-ciocanu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@jonaslagoni
Copy link
Member Author

Welcome among the champions @artur-ciocanu, happy to have you on board 🎉 Checkout the champions guideline here: https://github.com/asyncapi/modelina/blob/master/docs/champions.md

If you have any questions you can always reach out ✌️

@jonaslagoni jonaslagoni merged commit 3df0fe3 into master Dec 31, 2023
34 of 36 checks passed
@jonaslagoni jonaslagoni deleted the jonaslagoni-patch-1 branch December 31, 2023 00:24
@jonaslagoni
Copy link
Member Author

@all-contributors please add @artur-ciocanu for maintenance

Copy link
Contributor

@jonaslagoni

I've put up a pull request to add @artur-ciocanu! 🎉

@derberg
Copy link
Member

derberg commented Jan 3, 2024

@artur-ciocanu are you interested in joining us also as TSC member, like asyncapi/community#993 ?

@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 3.0.0-next.11 🎉

The release is available on:

Your semantic-release bot 📦🚀

@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 2.1.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants