Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: format command to convert asyncapi document to multiple format #1549

Conversation

catosaurusrex2003
Copy link
Contributor

Description
Added a new format command.
used js-yaml which was already a dependency.

-f flag defines the output format.
if -o flag is provided writes output to a file, else logs in the console.
image

Corner case checks
image

Help
image

Related issue(s)
#1535

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.

@catosaurusrex2003
Copy link
Contributor Author

catosaurusrex2003 commented Oct 19, 2024

should the tests be included in this PR or i create another one after this is finalized.

Edit: I have added the tests also

@Souvikns
Copy link
Member

@catosaurusrex2003 you have some lint issues, can you have a look.

@catosaurusrex2003
Copy link
Contributor Author

@Souvikns fixed

Copy link

sonarcloud bot commented Nov 17, 2024

@catosaurusrex2003
Copy link
Contributor Author

@Souvikns is something else required in this ?

@Souvikns
Copy link
Member

/rtm

@asyncapi-bot asyncapi-bot merged commit 260507f into asyncapi:master Nov 18, 2024
22 checks passed
@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 2.10.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants