Merge branch 'master' into issue-907-sidebar-broken

asyncapi · Oct 17, 2024 · 837bc81 · 837bc81
2 parents 738ab84 + 4253f29
commit 837bc81
Show file tree

Hide file tree

Showing 5 changed files with 9 additions and 19 deletions.
diff --git a/library/package.json b/library/package.json
@@ -1,6 +1,6 @@
 {
  "name": "@asyncapi/react-component",
- "version": "2.3.3",
+ "version": "2.3.4",
  "private": false,
  "description": "A React component for AsyncAPI specification.",
  "repository": {

diff --git a/library/src/components/Href.tsx b/library/src/components/Href.tsx
@@ -15,7 +15,7 @@ export const Href: React.FunctionComponent<Props> = ({
 }) => (
  <a
  href={href}
- title={title}
+ title={title ? `${title} (Opens in new window)` : 'Opens in new window'}
  className={className}
  target="_blank"
  rel="nofollow noopener noreferrer"

diff --git a/library/src/helpers/__tests__/schema.test.ts b/library/src/helpers/__tests__/schema.test.ts
@@ -896,21 +896,11 @@ describe('SchemaHelpers', () => {
 
  test('should not render title because title is undefined', () => {
  expect(
- SchemaHelpers.applicatorSchemaName(
- 0,
- FIRST_CASE,
- OTHER_CASES,
- undefined,
- ),
+ SchemaHelpers.applicatorSchemaName(0, FIRST_CASE, OTHER_CASES),
  ).toMatchSnapshot();
 
  expect(
- SchemaHelpers.applicatorSchemaName(
- 1,
- FIRST_CASE,
- OTHER_CASES,
- undefined,
- ),
+ SchemaHelpers.applicatorSchemaName(1, FIRST_CASE, OTHER_CASES),
  ).toMatchSnapshot();
  });
 

diff --git a/package-lock.json b/package-lock.json
diff --git a/web-component/package.json b/web-component/package.json
@@ -1,6 +1,6 @@
 {
  "name": "@asyncapi/web-component",
- "version": "2.3.3",
+ "version": "2.3.4",
  "private": false,
  "description": "A web component for AsyncAPI specification. Based on @asyncapi/react-component.",
  "repository": {
@@ -44,7 +44,7 @@
  "install:reactcomp": "chmod +x ./bump-react-comp.sh && ./bump-react-comp.sh"
  },
  "dependencies": {
- "@asyncapi/react-component": "^2.3.3",
+ "@asyncapi/react-component": "^2.3.4",
  "react": "^18.2.0",
  "react-dom": "^18.2.0",
  "web-react-components": "^1.4.2"