Skip to content

Commit

Permalink
Avoid ColumnFamilyDescriptor copy (facebook#10978)
Browse files Browse the repository at this point in the history
Summary:
Hi. :) Noticed we are copying ColumnFamilyDescriptor here because my process crashed during copy constructor (cause unrelated)

Pull Request resolved: facebook#10978

Reviewed By: cbi42

Differential Revision: D41473924

Pulled By: ajkr

fbshipit-source-id: 58a3473f2d7b24918f79d4b2726c20081c5e95b4
  • Loading branch information
igorcanadi authored and facebook-github-bot committed Mar 4, 2023
1 parent d053926 commit ddde1e6
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion db/db_impl/db_impl_open.cc
Original file line number Diff line number Diff line change
Expand Up @@ -216,7 +216,7 @@ Status ValidateOptionsByTable(
const DBOptions& db_opts,
const std::vector<ColumnFamilyDescriptor>& column_families) {
Status s;
for (auto cf : column_families) {
for (auto& cf : column_families) {
s = ValidateOptions(db_opts, cf.options);
if (!s.ok()) {
return s;
Expand Down

0 comments on commit ddde1e6

Please sign in to comment.