Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix date range params for events #440

Open
wants to merge 2 commits into
base: development
Choose a base branch
from
Open

Conversation

marksmall
Copy link

The date range params for when none exist where moment objects, not strings, which are being stringified in the network request. I'm now formatting the dates appropriately.

The date range params for when none exist where `moment` objects,
not strings, which are being stringified in the network request.
I'm now formatting the dates appropriately.
@marksmall marksmall self-assigned this Jun 2, 2023
This code was reading global state and assigning it to local state,
that is a big no-no. The selector already causes the component to
re-render when redux is updated.
Base automatically changed from wip-refactor to development June 7, 2023 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant