Added new combine function to compute the minimum and maximum #369
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #369 +/- ##
==========================================
+ Coverage 93.44% 93.51% +0.06%
==========================================
Files 25 25
Lines 870 879 +9
==========================================
+ Hits 813 822 +9
Misses 57 57
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
Thanks! I'll push some changes to resolve the conflicts and add 'min' as well, and add some tests. |
… map over all co-added arrays. This is useful for PSF calculations, for instance.
…xed implementation
astrofrog
changed the title
astrofrog
approved these changes
Sep 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I implemented a new combine function to compute the 2D maximum across the arrays/images to be mosaicked. It is helpful for PSF calculations, for instance.
It is a pretty straightforward addition.
Cheers.
Fabian