Optional opencv #43
Merged
Optional opencv #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Huh... Will have to investigate failure later... https://travis-ci.org/astropy/astrowidgets/jobs/420294263 |
mwcraig
requested changes
Aug 28, 2018
astrowidgets/core.py
Outdated
| try: | ||
| from ginga import trcalc | ||
| trcalc.use('opencv') | ||
| except (ImportError, ModuleNotFoundError) as exc: |
There was a problem hiding this comment.
Looks like ModuleNotFoundError is Python 3.6 and up only...but it subclasses from ImportError so just catching ImportError should be enough.
|
Thanks for the help, @mwcraig ! Tests pass now. 🎉 |
mwcraig
approved these changes
Aug 28, 2018
|
Thanks, merging! Hoping to put some concentrated time into this later this week/weekend. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #31
Also moved dev notes to https://github.com/astropy/astrowidgets/wiki/DevNotes and added link to example notebook to docs.