Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC: Setup doc layout, add installation notes #33

Merged
merged 2 commits into from
Aug 13, 2018

Conversation

pllim
Copy link
Member

@pllim pllim commented Aug 6, 2018

Fix #18

if sys.version_info < tuple((int(val) for val in __minimum_python_version__.split('.'))):
class UnsupportedPythonError(Exception):
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: Need to bury the exception class here to avoid automodapi to pick it up.

@@ -47,7 +47,7 @@ edit_on_github = True
github_project = astropy/astrowidgets
# install_requires should be formatted as a comma-separated list, e.g.:
# install_requires = astropy, scipy, matplotlib
install_requires = astropy, ginga, pillow, ipyevents, opencv-python
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: I had problem installing with opencv-python in the requirements even though I have opencv installed. So have to remove this one. Not sure how this didn't trip the CIs. 🤷‍♀️

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll try to explore in the next day or two. Could we keep ginga and pillow? At the moment they are needed to use the widget at all..

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK I added them back in setup.cfg.

@pllim pllim mentioned this pull request Aug 6, 2018
3 tasks
@pllim pllim requested review from mwcraig and eteq August 6, 2018 20:48
Copy link
Member

@mwcraig mwcraig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one small comment. In these days of conda I'm strongly inclined to include dependencies by default instead of making them optional.

@@ -47,7 +47,7 @@ edit_on_github = True
github_project = astropy/astrowidgets
# install_requires should be formatted as a comma-separated list, e.g.:
# install_requires = astropy, scipy, matplotlib
install_requires = astropy, ginga, pillow, ipyevents, opencv-python
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll try to explore in the next day or two. Could we keep ginga and pillow? At the moment they are needed to use the widget at all..

@mwcraig mwcraig merged commit 4a18bb7 into astropy:master Aug 13, 2018
@pllim pllim deleted the write-docs branch August 13, 2018 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants