-
-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOC: Setup doc layout, add installation notes #33
Conversation
if sys.version_info < tuple((int(val) for val in __minimum_python_version__.split('.'))): | ||
class UnsupportedPythonError(Exception): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note: Need to bury the exception class here to avoid automodapi
to pick it up.
@@ -47,7 +47,7 @@ edit_on_github = True | |||
github_project = astropy/astrowidgets | |||
# install_requires should be formatted as a comma-separated list, e.g.: | |||
# install_requires = astropy, scipy, matplotlib | |||
install_requires = astropy, ginga, pillow, ipyevents, opencv-python |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note: I had problem installing with opencv-python
in the requirements even though I have opencv
installed. So have to remove this one. Not sure how this didn't trip the CIs. 🤷♀️
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll try to explore in the next day or two. Could we keep ginga
and pillow
? At the moment they are needed to use the widget at all..
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK I added them back in setup.cfg
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one small comment. In these days of conda I'm strongly inclined to include dependencies by default instead of making them optional.
@@ -47,7 +47,7 @@ edit_on_github = True | |||
github_project = astropy/astrowidgets | |||
# install_requires should be formatted as a comma-separated list, e.g.: | |||
# install_requires = astropy, scipy, matplotlib | |||
install_requires = astropy, ginga, pillow, ipyevents, opencv-python |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll try to explore in the next day or two. Could we keep ginga
and pillow
? At the moment they are needed to use the widget at all..
Fix #18