-
-
Notifications
You must be signed in to change notification settings - Fork 180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Photutils getting started tutorial #99
Photutils getting started tutorial #99
Conversation
@bsipocz – Thanks! Maybe change the title from "Getting Started" to "Getting started with photutils" ... IMO the work "photutils" or "photometry" should be in the title, maybe "source detection" also. Also having sub-titles that include the key words like "source detection" and "photometry" would be nice, so that it's more prominent and can be linked to individually. And can you please link to the photutils project in the first sentence of the notebook and again at the end something like "If you want to learn more, go to the photutils docs [add link]". The line "from astropy.stats import median_absolute_deviation as mad" can be removed I think, it's not used. Otherwise, 👍 ! |
@cdeil - Good points, thanks. I'll update this tomorrow. |
Thanks, @bsipocz. For input cell 1, you can remove the import of |
Notebook is updated. |
@bsipocz - looks like a good start. Were you thinking of this as a starting point and are planning to add more, or want this as-is? For the content that's actually there, can I suggest a bit more introductory material? I.e., say briefly what the image is, and explain just a bit more about what's actually going on in each processing step. Personally I think it's better to view these tutorials as though you're teaching a class, as opposed to writing documentation. Does that make sense? A few other "mechanical" bits: you'll need to add a |
Oh, and along the lines above, you'll note that all the tutorials have "exercises" - I'd suggest you add just one or two to this so that they give the reader an opportunity to engage in the tutorial. |
@eteq - Thanks for the feedback, it's most useful. I (we) intended to have this in as is, and then maybe add another one (or extend this) later when someone has more time to spare. |
@bsipocz - I happen to notice this well looking at something else. I imagine it just slipped our minds... did you still want to take a crack at getting this in? |
I won't have time to finish this off now but can defer it until later for a hackday. With the recent changes most of this needs to be replaced probably. |
Hey @bsipocz! I'm going to close this for now in case any new contributors would like to take over the photometry tutorial (I don't want them to be discouraged by the open PR). Feel free to reopen if you have time to finish this off! |
Unless we do a tutorial focused sprint day it's super unlikely that I'll have any time to pick this up any time soon. |
This is to partially address #88.
cc: @larrybradley, @cdeil