Adding telescope constraints to the time_dependent plots #548
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmorris3
requested changes
Jul 27, 2023
| @@ -2,6 +2,7 @@ | |||
| from __future__ import (absolute_import, division, print_function, | |||
| unicode_literals) | |||
| import copy | |||
| from xmlrpc.client import boolean | |||
Comment on lines
+186
to
+202
|
|
||
| # Firstly, check that the constraints are valid if any. | ||
| if constraints is not None: | ||
| if isinstance(constraints, Constraint): | ||
| constraints = [constraints] | ||
|
|
||
| assert isinstance(constraints, (list, tuple, np.ndarray)), "constraints must be an array-like object or a single Constraint instance." | ||
| for cons in constraints: | ||
| assert isinstance(cons, Constraint), "All constraint objects must be Constraints" | ||
|
|
||
| # Make sure they're boolean | ||
| assert hasattr(cons, 'boolean_constraint'), "Each constraints element must have the 'boolean_constraint attribute." | ||
| assert cons.boolean_constraint, "Cannot work with non-boolean constraints." | ||
| # Then make sure they're not some weird user-generated constraint. | ||
| assert hasattr(cons, 'compute_constraint'), "Constraints must have a 'compute_constraint' method." | ||
|
|
||
|
|
There was a problem hiding this comment.
Rather than including asserts in the function here, a more common approach is to extract the elements of the list that meet the validation criteria, without raising an error.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
I'm proposing the addition of
Constraints to thetime_dependentplots, specificallyplot_airmass. Currently, my changes add a thick black line where the telescope constraints are not satisfied (i.e. the object is not observable when it's marked black).The figure above shows an example image with my custom
Constraintclass calledKeckVisibilitywhich takes into account the various telescope pointing constraints at Keck I and Keck II.I've not made any changes to the other plots yet as they're plotted somewhat differently but am happy to take suggestions for those as well.
Regards,
Sunil