Skip tasks that shouldn't run on skip_deploy #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @sunkickr @iancmoritz , any chance to review this PR? |
use $(git rev-parse HEAD^) instead of github.event.before, so squashed commits that are forced-pushed work
benjy44
force-pushed
the
main
branch
2 times, most recently
from
6efb7e8
to
b564d01
Compare
|
I've had the same issue that made me open this PR in the first place with the latest change pushed to wake up deployments. So I added the same change for those steps, ie: skip the steps that should not run on skip_deploy (without this change, the action breaks when preview deployment is being deleted) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had opened a PR earlier that was not properly tested, but this one should be better and tested, it fixes two issues we were facing with our deployments