fixing existing issues with DbtTestLocalOperator on_warning_callback #556
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
👷 Deploy Preview for amazing-pothos-a3bca0 processing.
|
…or build_and_run_cmd() method
navedgaras
had a problem deploying
to
external
GitHub Actions
Failure
tatiana
added a commit
that referenced
this pull request
Sep 27, 2023
tatiana
added a commit
that referenced
this pull request
Sep 27, 2023
|
We decided to merge the work and join the efforts in #558 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…method
Description
Due to changes in c7a203a DbtTestLocalOperator _handle_warnings was never triggered.
Related Issue(s)
Closes #549
Breaking Change?
I had made a minor change to the DbtLocalBaseOperator - result.output is logged in the execute() method instead of build_and_run_cmd(), shouldn't be a breaking change though.
Checklist