Adding emit_datasets param to DbtBaseOperator #551
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
👷 Deploy Preview for amazing-pothos-a3bca0 processing.
|
tatiana
reviewed
Sep 26, 2023
There was a problem hiding this comment.
Thanks a lot for the fix, @pgoslatara !
Would you be up for cherry-picking a test-case that covers this change so we avoid regression on this bug? I had created a test in 79f348b. If you'd rather not cherry-pick and create your own test, that would be fine as well!
tatiana
added a commit
that referenced
this pull request
Sep 27, 2023
Fix behaviour when using `ExecutionMode.KUBERNETES`, broken between the Cosmos releases 1.0.0 and 1.1.1. Update the documentation to be representative of the 1.x Cosmos interface: https://astronomer.github.io/astronomer-cosmos/getting_started/kubernetes.html Add unit tests to avoid regressions on these fixes. Part of the documentation fixes are made in: astronomer/cosmos-example#4 As a next step, we must ensure integration tests for running Cosmos on K8s to avoid this breaking change moving forward (issue #535). Closes: #493 Closes: #548 Closes: #534 Co-authored-by: Pádraic Slattery <[email protected]> (who created PR #551)
|
Thanks a lot for working on this, @pgoslatara ! I've merged your change as part of #554, since it includes tests and a few more bits. You are credited as a co-author! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When using the kubernetes execution mode I get this error:
This can be reproduced by following the README here, the relevant DAG file is here.
It appears that
emit_datasetsis not set inDbtBaseOperator, only inDbtLocalBaseOperator.Related Issue(s)
Breaking Change?
Checklist