Remove prefix of run and test tasks if test_behavior = TestBehavior.AFTER_EACH #524
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
👷 Deploy Preview for amazing-pothos-a3bca0 processing.
|
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #524 +/- ##
==========================================
+ Coverage 91.78% 91.80% +0.01%
==========================================
Files 49 49
Lines 1911 1915 +4
==========================================
+ Hits 1754 1758 +4
Misses 157 157
☔ View full report in Codecov by Sentry. |
tatiana
approved these changes
Sep 11, 2023
There was a problem hiding this comment.
Thanks for pointing out the redundancy in the TaskGroup and the inner Task names - this looks cleaner!
I just checked how it looked in the bigger view of the DAG, and it makes more sense:
I also confirmed that things looked good in the Task Instance list view and the Airflow Grid and Task Tries tabs.
tatiana
added a commit
that referenced
this pull request
Sep 14, 2023
Bug fixes * Fix attempt of emitting OpenLineage events if task execution fails by @tatiana in #526 * Fix Rust dependency for Windows users by @tatiana in #526 * Fix DbtRunOperationLocalOperator missing flags by @tatiana in #529 * Fix DbtRunLocalOperator to support the full refresh argument by @tatiana in #529 * Remove redundant prefix of task names when test_behavior = TestBehavior.AFTER_EACH by @binhnq94 in #524 * Fix rendering vars in `DbtModel` when using `LoadMode.CUSTOM` by @dojinkimm in #502 Others * Docs: add `documentation comparing Airflow and dbt concepts <https://astronomer.github.io/astronomer-cosmos/getting_started/dbt-airflow-concepts.html>`_ by @tatiana in #523. * Update PyPI project links by @tatiana in #528 * pre-commit updates
tatiana
added a commit
that referenced
this pull request
Sep 14, 2023
Bug fixes * Fix attempt of emitting OpenLineage events if task execution fails by @tatiana in #526 * Fix Rust dependency for Windows users by @tatiana in #526 * Fix DbtRunOperationLocalOperator missing flags by @tatiana in #529 * Fix DbtRunLocalOperator to support the full refresh argument by @tatiana in #529 * Remove redundant prefix of task names when test_behavior = TestBehavior.AFTER_EACH by @binhnq94 in #524 * Fix rendering vars in `DbtModel` when using `LoadMode.CUSTOM` by @dojinkimm in #502 Others * Docs: add `documentation comparing Airflow and dbt concepts <https://astronomer.github.io/astronomer-cosmos/getting_started/dbt-airflow-concepts.html>`_ by @tatiana in #523. * Update PyPI project links by @tatiana in #528 * pre-commit updates
Merged
harels
pushed a commit
that referenced
this pull request
Sep 14, 2023
Bug fixes * Remove redundant prefix of task names when test_behavior = TestBehavior.AFTER_EACH by @binhnq94 in #524 * Fix rendering vars in `DbtModel` when using `LoadMode.CUSTOM` by @dojinkimm in #502 * Fix attempt of emitting OpenLineage events if task execution fails by @tatiana in #526 * Fix Rust dependency for Windows users by @tatiana in #526 * Fix DbtRunOperationLocalOperator missing flags by @tatiana in #529 * Fix DbtRunLocalOperator to support the full refresh argument by @tatiana in #529 Others * Docs: add `documentation comparing Airflow and dbt concepts <https://astronomer.github.io/astronomer-cosmos/getting_started/dbt-airflow-concepts.html>`_ by @tatiana in #523. * Update PyPI project links by @tatiana in #528 * pre-commit updates
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If test_behavior = TestBehavior.AFTER_EACH, DbtNode.name in task_id is not necessary because the parent task group is named as
DbtNode.nameRelated Issue(s)
Slack thread
Breaking Change?
Remove prefix of run and test tasks if test_behavior = TestBehavior.AFTER_EACH.
Olds rendered tasks before this PR:
New rendered tasks:
Checklist