Refactor dbt project parsing and Airflow DAG generation #360
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
👷 Deploy Preview for amazing-pothos-a3bca0 processing.
|
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #360 +/- ##
==========================================
+ Coverage 88.94% 90.70% +1.75%
==========================================
Files 39 44 +5
Lines 1303 1484 +181
==========================================
+ Hits 1159 1346 +187
+ Misses 144 138 -6
☔ View full report in Codecov by Sentry. |
tatiana
commented
Jul 10, 2023
tatiana
commented
Jul 10, 2023
tatiana
commented
Jul 10, 2023
tatiana
commented
Jul 10, 2023
tatiana
force-pushed
the
issue-308-dbt-ls
branch
from
37bdcc5
to
35ed763
Compare
tatiana
changed the title
tatiana
force-pushed
the
issue-308-dbt-ls
branch
from
3200346
to
4358fd7
Compare
Summary of improvements: - Unify where tests dependencies are declared (hatch) - Unify command to run integration tests (hatch) - Have a single way of defining connection for tests (environment variable) - Clean up CI workflow to be compatible with the cleanup - Improve documentation on how to run integration tests locally
…e of the DbtGraph class
…ng the custom dbt project parser
tatiana
force-pushed
the
issue-308-dbt-ls
branch
from
35a58f1
to
1ed023f
Compare
jlaneve
approved these changes
Jul 17, 2023
This was referenced Jul 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a major refactor related to how we render
dbtprojects in Airflow.Some of the changes:
DbtDagandDbtTaskGroupdbtprojects from the actual Airflow DAG generationdbt lsmanifest.jsonBreaking changes:
from cosmos.dag import DbtDagis nowfrom cosmos.airflow.dag import DbtDagorfrom cosmos import DbtDagfrom cosmos.dag import DbtTaskGroupis nowfrom cosmos.airflow.dag import DbtTaskGrouporfrom cosmos import DbtTaskGroupselectandexcludearguments, passed toDbtDagorDbtTaskGroupused to be dictionaries, now they are lists - so we are compatible with the representation in dbtDISCLAIMER: This PR is in draft mode because I'm improving the following:
(features)
DbtToAirflowConverterclassdbt lsexpects the user to have a validprofiles.yml- we can extract the logic from the local executor. It feels we could do this in a follow-up PR(test features we lack integration tests)
(good practices)
Closes: #308