CI Workaround: Pin dbt-core, Disable SQLite Tests, and Correctly Ignore Clone Test to Pass CI #1337
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying astronomer-cosmos with
|
| Latest commit: |
6f61b47
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://2e9ad260.astronomer-cosmos.pages.dev |
| Branch Preview URL: | https://fix-ci.astronomer-cosmos.pages.dev |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1337 +/- ##
==========================================
- Coverage 96.03% 96.02% -0.02%
==========================================
Files 67 67
Lines 3988 4025 +37
==========================================
+ Hits 3830 3865 +35
- Misses 158 160 +2 ☔ View full report in Codecov by Sentry. |
|
|
dosubot
bot
added
size:L
tatiana
reviewed
Nov 26, 2024
There was a problem hiding this comment.
Hi @pankajastro , thank you very much for working around and logging these issues to make the CI red. It's a lot. It may be worth to rename the PR title, since we're doing much more than just pinning versions, what do you think? A minor question inline and I'll approve it.
tatiana
reviewed
Nov 26, 2024
pankajastro
changed the title
tatiana
approved these changes
Nov 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #1335
eval_type_backportin tests and created an issue Remove dependencyeval_type_backportfrom tests #1342 to remove itCI success: https://github.com/astronomer/astronomer-cosmos/actions/runs/12026097151/job/33524412817?pr=1337