-
Notifications
You must be signed in to change notification settings - Fork 161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Replace login by user for clickhouse profile #1255
fix: Replace login by user for clickhouse profile #1255
Conversation
✅ Deploy Preview for sunny-pastelito-5ecb04 canceled.
|
fc001ab
to
8b3f971
Compare
8b3f971
to
8cfc3df
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, @petershenri Thank you for fixing it.
Can I let you merge it to main ? |
8cfc3df
to
fb9e53f
Compare
We will merge it once CI is green |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1255 +/- ##
=======================================
Coverage 95.73% 95.73%
=======================================
Files 67 67
Lines 3965 3965
=======================================
Hits 3796 3796
Misses 169 169 ☔ View full report in Codecov by Sentry. |
@petershenri, thank you very much for reporting/fixing this issue. |
It works as expected on my docker. |
Description
The clickhouse profile is currently not working. Changing the login parameter to user
Related Issue(s)
closes #1249
Breaking Change?
No
Checklist