fix: Replace login by user for clickhouse profile #1255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:XS
✅ Deploy Preview for sunny-pastelito-5ecb04 canceled.
|
petershenri
force-pushed
the
dev/profile_clichouse_fix
branch
from
fc001ab
to
8b3f971
Compare
petershenri
force-pushed
the
dev/profile_clichouse_fix
branch
from
8b3f971
to
8cfc3df
Compare
pankajastro
approved these changes
Oct 15, 2024
|
Can I let you merge it to main ? |
petershenri
force-pushed
the
dev/profile_clichouse_fix
branch
from
8cfc3df
to
fb9e53f
Compare
dosubot
bot
added
size:S
We will merge it once CI is green |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1255 +/- ##
=======================================
Coverage 95.73% 95.73%
=======================================
Files 67 67
Lines 3965 3965
=======================================
Hits 3796 3796
Misses 169 169 ☔ View full report in Codecov by Sentry. |
|
@petershenri, thank you very much for reporting/fixing this issue. |
|
It works as expected on my docker. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The clickhouse profile is currently not working. Changing the login parameter to user
Related Issue(s)
closes #1249
Breaking Change?
No
Checklist