Skip to content

Commit

Permalink
Improve CI performance - replace flake8 for ruff (#743)
Browse files Browse the repository at this point in the history
We are using ruff, which has drop-in parity with flake8. 
We can continue using only ruff and shave a few seconds of CI.

Related #738
  • Loading branch information
joppevos authored Dec 5, 2023
1 parent d2248b7 commit 2988649
Show file tree
Hide file tree
Showing 2 changed files with 18 additions and 15 deletions.
25 changes: 14 additions & 11 deletions .pre-commit-config.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ repos:
- id: end-of-file-fixer
- id: mixed-line-ending
- id: pretty-format-json
args: ['--autofix']
args: ["--autofix"]
- id: trailing-whitespace
- repo: https://github.com/codespell-project/codespell
rev: v2.2.6
Expand Down Expand Up @@ -63,30 +63,33 @@ repos:
rev: 23.11.0
hooks:
- id: black
args: [ "--config", "./pyproject.toml" ]
args: ["--config", "./pyproject.toml"]
- repo: https://github.com/asottile/blacken-docs
rev: 1.16.0
hooks:
- id: blacken-docs
alias: black
additional_dependencies: [black>=22.10.0]
- repo: https://github.com/pre-commit/mirrors-mypy
rev: 'v1.7.1'
rev: "v1.7.1"

hooks:
- id: mypy
name: mypy-python
additional_dependencies: [types-PyYAML, types-attrs, attrs, types-requests, types-python-dateutil, apache-airflow]
additional_dependencies:
[
types-PyYAML,
types-attrs,
attrs,
types-requests,
types-python-dateutil,
apache-airflow,
]
files: ^cosmos
- repo: https://github.com/pycqa/flake8
rev: 6.1.0
hooks:
- id: flake8
entry: pflake8
additional_dependencies: [pyproject-flake8]

ci:
autofix_commit_msg: 🎨 [pre-commit.ci] Auto format from pre-commit.com hooks
autoupdate_commit_msg: ⬆ [pre-commit.ci] pre-commit autoupdate
skip:
- mypy # build of https://github.com/pre-commit/mirrors-mypy:types-PyYAML,types-attrs,attrs,types-requests,
- mypy # build of https://github.com/pre-commit/mirrors-mypy:types-PyYAML,types-attrs,attrs,types-requests,
#types-python-dateutil,[email protected] for python@python3 exceeds tier max size 250MiB: 262.6MiB
8 changes: 4 additions & 4 deletions pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -255,10 +255,10 @@ no_warn_unused_ignores = true

[tool.ruff]
line-length = 120
[tool.ruff.lint]
select = ["C901"]
[tool.ruff.lint.mccabe]
max-complexity = 8

[tool.distutils.bdist_wheel]
universal = true

[tool.flake8]
max-complexity = 8
select = "C"

0 comments on commit 2988649

Please sign in to comment.