Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix running make docker-run when there is a new version #99

Merged
merged 1 commit into from
Nov 28, 2024

Conversation

tatiana
Copy link
Collaborator

@tatiana tatiana commented Nov 28, 2024

Previoulsy, we never deleted wheels. The consequence is that the include directory would contain multiple versions of the Ray provider package, which would raise an exception when trying to run make docker-run.

Example of error:


0.608 The conflict is caused by:
0.608     The user requested astro-provider-ray 0.2.1 (from /usr/local/airflow/include/astro_provider_ray-0.2.1-py3-none-any.whl)
0.608     The user requested astro-provider-ray 0.3.0a7 (from /usr/local/airflow/include/astro_provider_ray-0.3.0a7-py3-none-any.whl)
0.608
0.608 To fix this you could try to:
0.608 1. loosen the range of package versions you've specified
0.608 2. remove package versions to allow pip to attempt to solve the dependency conflict
0.608
0.825
0.825 [notice] A new release of pip is available: 24.2 -> 24.3.1
0.825 [notice] To update, run: pip install --upgrade pip
0.826 ERROR: ResolutionImpossible: for help visit https://pip.pypa.io/en/latest/topics/dependency-resolution/#dealing-with-dependency-conflicts
------
Dockerfile:25
--------------------
  23 |     USER astro
  24 |
  25 | >>> RUN pip install /usr/local/airflow/include/*.whl
  26 |
--------------------
ERROR: failed to solve: process "/bin/bash -o pipefail -e -u -x -c pip install /usr/local/airflow/include/*.whl" did not complete successfully: exit code: 1

View build details: docker-desktop://dashboard/build/desktop-linux/desktop-linux/17i8mx9qdqmd7fb72fe3uxjxc
Error: command 'docker build -t dev_c226a1/airflow:latest failed: failed to execute cmd: exit status 1
make: *** [docker-run] Error 1
```

Previoulsy, we never deleted wheels. The consequence is that the
include directory would contain multiple versions of the Ray provider
package, which would raise an exception when trying to run `make docker-run`.

Example of error:
````

0.608 The conflict is caused by:
0.608     The user requested astro-provider-ray 0.2.1 (from /usr/local/airflow/include/astro_provider_ray-0.2.1-py3-none-any.whl)
0.608     The user requested astro-provider-ray 0.3.0a7 (from /usr/local/airflow/include/astro_provider_ray-0.3.0a7-py3-none-any.whl)
0.608
0.608 To fix this you could try to:
0.608 1. loosen the range of package versions you've specified
0.608 2. remove package versions to allow pip to attempt to solve the dependency conflict
0.608
0.825
0.825 [notice] A new release of pip is available: 24.2 -> 24.3.1
0.825 [notice] To update, run: pip install --upgrade pip
0.826 ERROR: ResolutionImpossible: for help visit https://pip.pypa.io/en/latest/topics/dependency-resolution/#dealing-with-dependency-conflicts
------
Dockerfile:25
--------------------
  23 |     USER astro
  24 |
  25 | >>> RUN pip install /usr/local/airflow/include/*.whl
  26 |
--------------------
ERROR: failed to solve: process "/bin/bash -o pipefail -e -u -x -c pip install /usr/local/airflow/include/*.whl" did not complete successfully: exit code: 1

View build details: docker-desktop://dashboard/build/desktop-linux/desktop-linux/17i8mx9qdqmd7fb72fe3uxjxc
Error: command 'docker build -t dev_c226a1/airflow:latest failed: failed to execute cmd: exit status 1
make: *** [docker-run] Error 1
```
@tatiana tatiana merged commit b200897 into main Nov 28, 2024
21 checks passed
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.22%. Comparing base (be298c8) to head (2a3dfcf).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #99   +/-   ##
=======================================
  Coverage   98.22%   98.22%           
=======================================
  Files           5        5           
  Lines         564      564           
=======================================
  Hits          554      554           
  Misses         10       10           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants