Integration test fix & Decorator change task.ray() -> ray.task() #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
venkatajagannath
temporarily deployed
to
internal
GitHub Actions
Inactive
venkatajagannath
temporarily deployed
to
internal
GitHub Actions
Inactive
venkatajagannath
temporarily deployed
to
internal
GitHub Actions
Inactive
venkatajagannath
changed the title
venkatajagannath
temporarily deployed
to
internal
GitHub Actions
Inactive
venkatajagannath
temporarily deployed
to
internal
GitHub Actions
Inactive
venkatajagannath
temporarily deployed
to
internal
GitHub Actions
Inactive
venkatajagannath
temporarily deployed
to
internal
GitHub Actions
Inactive
venkatajagannath
added
bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes 2 changes
Decorator change
Using task.ray() in a DAG might requires us to provide an alias to base object task().
e.g:
from airflow.decorators import dag, task as airflow_task
from ray_provider.decorators.ray import task
Its better to not to have to give a different alias to the the main object in the taskflow api. So, I'm changing the code to be ray.task()
Integration test fix
We want to make sure our cluster name is unique if we are creating a GKE cluster. So, making changes to that portion.
Also, reducing the amount of resources allocated to the k8 cluster to control costs