-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release 1.2.0 #66
Closed
Closed
Release 1.2.0 #66
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,5 @@ | ||
# flake8: noqa F401 | ||
__version__ = "1.1.2" | ||
__version__ = "1.2.0" | ||
|
||
import logging | ||
|
||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
qq on whether these breaking changes call for a major semver release? or if it's possible to avoid having breaking changes?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My $0.02 is they are extremely minor breakages that will impact almost no users. I hesitate to even call attention to them; I am just very thorough.
Also, this is outdated and no longer true:
We resolved this by adding a (deprecated) kwarg to each of those methods.
The changes in #58 would certainly constitute a major version bump, though, if that gets merged before the release. (Working on resolving that right now, sorry for delays.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To clarify:
reschedule_time=0
and also relying on the default behavior of not actually waiting 0 seconds.prep_connector
, which was alwaysTrue
, unless they misunderstood it to sometimes return False and used its truthiness to do something.check_connector
, which originally returnedTrue
always.These really do seem to constitute minor changes, in my eyes. These are changes that are relatively deep in the API, with return values changing that had no real use anyway. The only high-level-API-facing change was to make a
0
default into aNone
default so that the0
could meansleep(0)
. Even that is not especially consequential of a change in the very rare event a user would be impacted; it would just mean that manual resyncs get rescheduled faster than normal, and it could even have been what the user originally intended if they were explicitly setting it!