Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release 1.2.0 #66

Closed
wants to merge 1 commit into from
Closed

Release 1.2.0 #66

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,22 @@
# Changelog

## 1.2.0 (2023-10-31)

### Breaking changes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

qq on whether these breaking changes call for a major semver release? or if it's possible to avoid having breaking changes?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My $0.02 is they are extremely minor breakages that will impact almost no users. I hesitate to even call attention to them; I am just very thorough.

Also, this is outdated and no longer true:

For users using the sync hook directly to call either get_sync_status or call_and_restart, they will experience breakage if they are using reschedule_time=

We resolved this by adding a (deprecated) kwarg to each of those methods.

The changes in #58 would certainly constitute a major version bump, though, if that gets merged before the release. (Working on resolving that right now, sorry for delays.)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To clarify:

  • I cannot imagine any users setting reschedule_time=0 and also relying on the default behavior of not actually waiting 0 seconds.
  • I cannot imagine any users relying on the return value of prep_connector, which was always True, unless they misunderstood it to sometimes return False and used its truthiness to do something.
  • Same as above for check_connector, which originally returned True always.

These really do seem to constitute minor changes, in my eyes. These are changes that are relatively deep in the API, with return values changing that had no real use anyway. The only high-level-API-facing change was to make a 0 default into a None default so that the 0 could mean sleep(0). Even that is not especially consequential of a change in the very rare event a user would be impacted; it would just mean that manual resyncs get rescheduled faster than normal, and it could even have been what the user originally intended if they were explicitly setting it!

- FivetranHook.check_connector now returns the connector_details dict object by @dwreeves in https://github.com/astronomer/airflow-provider-fivetran-async/pull/54
- FivetranHook.prep_connector now returns None instead of Literal[True] by @dwreeves in https://github.com/astronomer/airflow-provider-fivetran-async/pull/54
- For users using the sync hook directly to call either get_sync_status or call_and_restart, they will experience breakage if they are using reschedule_time=
and for users who manually set =0, they will also experience breakage by @dwreeves in https://github.com/astronomer/airflow-provider-fivetran-async/pull/57

### Bug fixes
- Use dynamic operator value in link by @pankajastro in https://github.com/astronomer/airflow-provider-fivetran-async/pull/56
- Update the registry URL for FivetranOperator by @utkarsharma2 in https://github.com/astronomer/airflow-provider-fivetran-async/pull/52
- Updated quotation placement to fix `TypeError` by @cSaller in https://github.com/astronomer/airflow-provider-fivetran-async/pull/65

### Misc
- Add mypy + some other misc. changes by @dwreeves in https://github.com/astronomer/airflow-provider-fivetran-async/pull/54
- Consolidate api for `pause_and_restart` and `_parse_timestamp` methods by @dwreeves in https://github.com/astronomer/airflow-provider-fivetran-async/pull/57

## 1.1.2 (2023-08-10)

### Bug fixes
Expand Down
2 changes: 1 addition & 1 deletion fivetran_provider_async/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
# flake8: noqa F401
__version__ = "1.1.2"
__version__ = "1.2.0"

import logging

Expand Down