remove distutils function and change packaging.version #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #37 +/- ##
==========================================
- Coverage 88.43% 88.38% -0.05%
==========================================
Files 11 11
Lines 536 534 -2
==========================================
- Hits 474 472 -2
Misses 62 62
☔ View full report in Codecov by Sentry. |
ifurther
force-pushed
the
master
branch
3 times, most recently
from
d5bf042
to
6feedab
Compare
|
Thanks for the PR! I have rebased this now that I've fixed the CI infrastructure. |
|
We no longer need to use setup.py and we also don't need to check for the version in the tests anymore so actually simplifying this by removing the deprecated code. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
distutils is removed in new version python