Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test coverage for use of git without feature flag #10874

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Add test coverage for use of git without feature flag #10874

wants to merge 3 commits into from
+45 −2

Conversation

zanieb
Copy link
Member

@zanieb zanieb commented Jan 22, 2025 •
edited
Loading

Shoves a broken git executable onto the front of the PATH in the test context when the git feature is disabled so they fail if they're missing the feature-gate.

@zanieb zanieb added the internal A refactor or improvement that is not user-facing label Jan 22, 2025
@zanieb zanieb temporarily deployed to uv-test-publish January 22, 2025 19:53 — with GitHub Actions Inactive
@zanieb zanieb temporarily deployed to uv-test-publish January 22, 2025 20:06 — with GitHub Actions Inactive
@zanieb zanieb force-pushed the zb/disable-git branch 3 times, most recently from c48e963 to d71c696 Compare January 22, 2025 20:46
@zanieb zanieb temporarily deployed to uv-test-publish January 22, 2025 20:51 — with GitHub Actions Inactive
@zanieb zanieb changed the title Test if git is used without flagging Add test coverage for use of git without feature flag Jan 22, 2025
@zanieb zanieb marked this pull request as ready for review January 22, 2025 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
internal A refactor or improvement that is not user-facing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@zanieb