Add multistage Docker example #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zanieb
force-pushed
the
zb/multistage
branch
2 times, most recently
from
f5077a3
to
9062e98
Compare
konstin
approved these changes
Sep 4, 2024
| To build the multistage image: | ||
|
|
||
| ```console | ||
| $ docker build . --file Dockerfile.multistage |
There was a problem hiding this comment.
TIL buildx is now the default builder
| ENV PATH="/app/.venv/bin:$PATH" | ||
|
|
||
| # Run the FastAPI application by default | ||
| CMD ["fastapi", "dev", "--host", "0.0.0.0", "/app/src/uv_docker_example"] |
There was a problem hiding this comment.
Is it intentional that this uses dev instead of run?
There was a problem hiding this comment.
So far, these examples target the dev experience with bind mounts — so yeah. We should probably be clear about what you'd want different in production builds.
zanieb
force-pushed
the
zb/multistage
branch
from
9062e98
to
8b7d86a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #11