Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ruff] Handle attrs's auto_attribs correctly (RUF009) #14520

Merged
merged 2 commits into from
Nov 24, 2024
Merged

[ruff] Handle attrs's auto_attribs correctly (RUF009) #14520

merged 2 commits into from
Nov 24, 2024
+303 −19

Conversation

InSyncWithFoo
Copy link
Contributor

Summary

Resolves #14519.

Test Plan

cargo nextest run and cargo insta test.

@InSyncWithFoo InSyncWithFoo changed the title [ruff] Handle attrs's auto_attribs correctly (RUF009`) [ruff] Handle attrs's auto_attribs correctly (RUF009) Nov 22, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 22, 2024 •
edited
Loading

ruff-ecosystem results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

✅ ecosystem check detected no linter changes.

charliermarsh
charliermarsh approved these changes Nov 24, 2024
View reviewed changes
Copy link
Member

@charliermarsh charliermarsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely done, thanks.

@charliermarsh charliermarsh merged commit d285717 into astral-sh:main Nov 24, 2024
20 checks passed
@charliermarsh charliermarsh added the bug Something isn't working label Nov 24, 2024
@InSyncWithFoo InSyncWithFoo deleted the RUF009 branch November 24, 2024 04:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@charliermarsh charliermarsh charliermarsh approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

RUF009 handles attrs dataclasses with auto_attribs = False incorrectly
2 participants
@InSyncWithFoo @charliermarsh