Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid inferring invalid expr types for string annotation #14447

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Avoid inferring invalid expr types for string annotation #14447

wants to merge 1 commit into from
+32 −1

Conversation

dhruvmanila
Copy link
Member

@dhruvmanila dhruvmanila commented Nov 19, 2024 •
edited
Loading

Summary

fixes: #14440

Test Plan

Add a test case with all the invalid expressions in a string annotation context.

@dhruvmanila dhruvmanila added the red-knot Multi-file analysis & type inference label Nov 19, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 19, 2024 •
edited
Loading

ruff-ecosystem results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

✅ ecosystem check detected no linter changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carljm carljm Awaiting requested review from carljm carljm will be requested when the pull request is marked ready for review carljm is a code owner

@MichaReiser MichaReiser Awaiting requested review from MichaReiser MichaReiser will be requested when the pull request is marked ready for review MichaReiser is a code owner

@AlexWaygood AlexWaygood Awaiting requested review from AlexWaygood AlexWaygood will be requested when the pull request is marked ready for review AlexWaygood is a code owner

@sharkdp sharkdp Awaiting requested review from sharkdp sharkdp will be requested when the pull request is marked ready for review sharkdp is a code owner

Assignees
No one assigned
Labels
red-knot Multi-file analysis & type inference
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[red-knot] Panics for string annotations
1 participant
@dhruvmanila