[flake8-pyi] Apply redundant-numeric-union to more type expressions (PYI041)

crates/ruff_linter/resources/test/fixtures/flake8_pyi/PYI041.py

@@ -39,9 +39,41 @@ async def f4(**kwargs: int | int | float) -> None:
     ...
 
 
+def f5(
+    arg: Union[  # comment 
+        float, # another
+        complex, int]
+    ) -> None: 
+    ...
+
+def f6(
+    arg: (
+        int | # comment
+        float |  # another
+        complex
+    )    
+    ) -> None: 
+    ...
+
+
 class Foo:
     def good(self, arg: int) -> None:
         ...
 
     def bad(self, arg: int | float | complex) -> None:
         ...
+
+    def bad2(self, arg: int | Union[float, complex]) -> None: 
+        ...
+
+    def bad3(self, arg: Union[Union[float, complex], int]) -> None: 
+        ...
+
+    def bad4(self, arg: Union[float | complex, int]) -> None: 
+        ...
+
+    def bad5(self, arg: int | (float | complex)) -> None: 
+        ...
+
+    def bad6(self) -> int | (float | complex):
+        ...

crates/ruff_linter/resources/test/fixtures/flake8_pyi/PYI041.pyi

@@ -32,8 +32,31 @@ def f3(arg1: int, *args: Union[int | int | float]) -> None: ...  # PYI041
 
 async def f4(**kwargs: int | int | float) -> None: ...  # PYI041
 
+def f5(
+    arg: Union[  # comment 
+        float, # another
+        complex, int]
+    ) -> None: ...  # PYI041
+
+def f6(
+    arg: (
+        int | # comment
+        float |  # another
+        complex
+    )    
+    ) -> None: ... # PYI041
 
 class Foo:
     def good(self, arg: int) -> None: ...
 
     def bad(self, arg: int | float | complex) -> None: ...  # PYI041
+
+    def bad2(self, arg: int | Union[float, complex]) -> None: ...  # PYI041
+
+    def bad3(self, arg: Union[Union[float, complex], int]) -> None: ...  # PYI041
+
+    def bad4(self, arg: Union[float | complex, int]) -> None: ...  # PYI041
+
+    def bad5(self, arg: int | (float | complex)) -> None: ...  # PYI041
+
+    def bad6(self) -> int | (float | complex): ...  # PYI041

crates/ruff_linter/src/checkers/ast/analyze/expression.rs

@@ -80,6 +80,7 @@ pub(crate) fn expression(expr: &Expr, checker: &mut Checker) {
                 Rule::DuplicateUnionMember,
                 Rule::RedundantLiteralUnion,
                 Rule::UnnecessaryTypeUnion,
+                Rule::RedundantNumericUnion,
             ]) {
                 // Avoid duplicate checks if the parent is a union, since these rules already
                 // traverse nested unions.
@@ -96,6 +97,9 @@ pub(crate) fn expression(expr: &Expr, checker: &mut Checker) {
                     if checker.enabled(Rule::UnnecessaryTypeUnion) {
                         flake8_pyi::rules::unnecessary_type_union(checker, expr);
                     }
+                    if checker.enabled(Rule::RedundantNumericUnion) {
+                        flake8_pyi::rules::redundant_numeric_union(checker, expr);
+                    }
                 }
             }
 
@@ -1273,6 +1277,9 @@ pub(crate) fn expression(expr: &Expr, checker: &mut Checker) {
                 if checker.enabled(Rule::RuntimeStringUnion) {
                     flake8_type_checking::rules::runtime_string_union(checker, expr);
                 }
+                if checker.enabled(Rule::RedundantNumericUnion) {
+                    flake8_pyi::rules::redundant_numeric_union(checker, expr);
+                }
             }
         }
         Expr::UnaryOp(

crates/ruff_linter/src/checkers/ast/analyze/statement.rs

@@ -184,9 +184,6 @@ pub(crate) fn statement(stmt: &Stmt, checker: &mut Checker) {
             if checker.enabled(Rule::BadExitAnnotation) {
                 flake8_pyi::rules::bad_exit_annotation(checker, function_def);
             }
-            if checker.enabled(Rule::RedundantNumericUnion) {
-                flake8_pyi::rules::redundant_numeric_union(checker, parameters);
-            }
             if checker.enabled(Rule::PrePep570PositionalArgument) {
                 flake8_pyi::rules::pre_pep570_positional_argument(checker, function_def);
             }