Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix get examples for diploid case #44

Merged
merged 1 commit into from
May 24, 2024

Conversation

szhan
Copy link
Collaborator

@szhan szhan commented May 23, 2024

Fix #43

@szhan
Copy link
Collaborator Author

szhan commented May 23, 2024

For now, it should raise an error when using the including ancestors option, because it is not correctly implemented yet.

@szhan
Copy link
Collaborator Author

szhan commented May 23, 2024

I suspect that there is a bug as well, because the tests fail when a query has only MISSING, which should work.

@szhan
Copy link
Collaborator Author

szhan commented May 23, 2024

It turns out that there is no bug as suspected above. It's just that one of the tests ran into a pathological case where both the mutation rate and recombination rate are very low (1e-6) and there is no normalisation, resulting in comparisons of extremely low log-likelihood values (nearly 1e-15).

As discussed with @astheeggeggs , one way around this is to run all the tests on the non-extreme parameter value combinations, so as to avoid comparisons of extremely low LL values; then, proceed to run the tests on the extreme parameter value combinations with normalisation.

@szhan
Copy link
Collaborator Author

szhan commented May 23, 2024

The above should be fixed in a separate issue.

@szhan szhan force-pushed the fix_tests_diploid branch from 64756c0 to e25b505 Compare May 23, 2024 11:15
@szhan
Copy link
Collaborator Author

szhan commented May 23, 2024

Also, for now, the tests are not covering cases when the ref. panel contains partial ancestral haplotypes with NONCOPY.

@szhan szhan force-pushed the fix_tests_diploid branch from f6509d1 to 167764a Compare May 23, 2024 13:03
@astheeggeggs astheeggeggs merged commit 0c2b7a8 into astheeggeggs:main May 24, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix get_examples_diploid in tests
2 participants