Exclude MISSING when counting alleles per site #34
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #33
I reworked
check_alleles
inlshmm/api.py
.I implemented a helper function
_get_num_alleles
, which has the same logic ascheck_alleles
, in the following two test files:test_API.py
test_API_multiallelic.py
The above sets of tests pass.
I did not make any changes to
test_LS_haploid_diploid.py
, because there is no testing of FB when mutation rates are scaled by the number of distinct alleles.Also, I'm only dealing with
MISSING
here. I'll addNONCOPY
to the exclusion set in #31.