Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests when prob_mutation is not specified #106

Merged
merged 1 commit into from
Jun 18, 2024

Conversation

szhan
Copy link
Collaborator

@szhan szhan commented Jun 18, 2024

Fix #70

@szhan
Copy link
Collaborator Author

szhan commented Jun 18, 2024

When using estimate_mutation_probability, a pathological case happened when the number of ref. haplotypes is 2 when running test_ts_simple_n6, because four haplotypes (which are then used as queries) are excluded from the simulated ref. panel. See #108

@szhan
Copy link
Collaborator Author

szhan commented Jun 18, 2024

A temporary workaround is to not exclude the haplotypes chosen as queries from the ref. panel used downstream. The proper way is to rework get_examples* so that no haplotypes are excluded from the simulated ref. panel but the query haplotypes are randomly mutated copies of some of the haplotypes in the ref. panel. This will be addressed in a separate issue.

@szhan szhan force-pushed the add_tests_prob_mutation_none branch from d450901 to e8536c9 Compare June 18, 2024 11:14
@szhan szhan force-pushed the add_tests_prob_mutation_none branch from 7e7efa3 to 7107a35 Compare June 18, 2024 11:16
@szhan szhan merged commit 309aa18 into astheeggeggs:main Jun 18, 2024
4 checks passed
@szhan szhan deleted the add_tests_prob_mutation_none branch June 18, 2024 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add tests for set_emission_probabilities when prob_mutation is not specified
1 participant