Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Noise gate augmentation #142

Open
wants to merge 12 commits into
base: main
Choose a base branch
from
Open

Conversation

shahules786
Copy link
Contributor

Implemented spectral gating based on https://timsainburg.com/noise-reduction-python.html
Can you check this and let me know what you think? @iver56
I will implement the tests after the review if that's fine.

@iver56 iver56 self-requested a review May 12, 2022 07:17
Copy link
Collaborator

@iver56 iver56 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the initiative! It would be nice if you could add it to the demo script as well, so we can listen to what it sounds like :)

torch_audiomentations/augmentations/noise_gates.py Outdated Show resolved Hide resolved
@shahules786
Copy link
Contributor Author

Thanks for the initiative! It would be nice if you could add it to the demo script as well, so we can listen to what it sounds like :)

Done.

@shahules786 shahules786 requested a review from iver56 May 13, 2022 11:50
@iver56
Copy link
Collaborator

iver56 commented May 18, 2022

I listened to an output from the demo script now, and I can hear a buzzy sound that was somehow added to my original sound. I did not expect this. Maybe something is wrong with the implementation? I can also see it in the spectrogram:
spectralgating

I expected something more like this:

spectralgating-expected

(I created this "expected" example with Audacity's built-in noise reduction plugin)

Here are the 3 wavs that I compared in those two spectrogram gifs:
spectral_gating_sounds.zip

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants