binaries in rpms and ci refactor #6
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* refactor CI build to drop Docker * CI build now has six parallel builds that take a max of 6 min * only clone a single commit * always tail logs, in case of false positives
| - [kube-controller-manager](#kube-controller-manager) | ||
| - [kube-scheduler](#kube-scheduler) | ||
| - [kubectl](#kubectl) | ||
| - [kubelet](#kubelet) |
There was a problem hiding this comment.
don't we need kube-proxy too?
|
nice, lgtm. just the one question on kube-proxy |
|
@ryane That would be good to have, huh 😄 |
[skip ci]
|
actually we should probably update |
|
just realized that we do lose the kube2consul image with this. we still need to build that image until MustWin/kubernetes#12 is addressed |
|
This PR is on hold for now, since we probably still want to run k8s in k8s. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #4