add newlines back to logs, add unit tests #38

langston-barrett · 2016-06-17T21:46:14Z

fixes #36

langston-barrett · 2016-06-17T21:51:00Z

Note that this PR contains several TODO items. These are tests that I believe should pass, but don't currently, and I can't figure out why. I believe their failure is the key to #27.

langston-barrett · 2016-07-29T14:58:50Z

@BrianHicks Can I get a review on this? Still having this problem with the newlines: https://travis-ci.org/siddharthist/kubernetes-packaging/jobs/148331420

BrianHicks · 2016-07-29T15:58:50Z

hammer/logs.go


 for line := range src {
- _, err = file.Write(line)
+ _, err = file.Write(append(line, []byte("\n")...))


append(line, '\n')

langston-barrett added 3 commits June 17, 2016 22:43

logs: add unit tests, fix small bugs

e50ffb1

fixes #36

make two separate logs for stdout and stderr

1fcfa6f

test stdout and stderr files separately

e837f51

BrianHicks reviewed Jul 29, 2016
View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

add newlines back to logs, add unit tests #38

add newlines back to logs, add unit tests #38

langston-barrett commented Jun 17, 2016

langston-barrett commented Jun 17, 2016

langston-barrett commented Jul 29, 2016

BrianHicks Jul 29, 2016

add newlines back to logs, add unit tests #38

Are you sure you want to change the base?

add newlines back to logs, add unit tests #38

Conversation

langston-barrett commented Jun 17, 2016

langston-barrett commented Jun 17, 2016

langston-barrett commented Jul 29, 2016

BrianHicks Jul 29, 2016

Choose a reason for hiding this comment