Add support for discriminator on native enums properties #210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…[command] Options: -V, --version output the version number -d, --sdkDir <sdkDir> sdkDir, default: process.cwd()/service -t, --templatePath <templatePath> templatePath -t, --type <type> ts/js, default ts -c, --camelCase <camelCase> filename style, true 为大驼峰，lower 为小驼峰 -d, --sdkDir <sdkDir> sdkDir, default: process.cwd()/service -t, --templatePath <templatePath> templatePath -t, --type <type> ts/js, default ts -c, --camelCase <camelCase> filename style, true 为大驼峰，lower 为小驼峰 -h, --help output usage information Commands: url <url> swagger2/oas3 json data url data <filePath> swagger2/oas3 json data file config <cfgPath> config path *
…ject added format: date-time to for in Usage: openapi-generator [options…
removed old change I made on dates
AGalabov
reviewed
Mar 1, 2024
There was a problem hiding this comment.
@shaikegross thank you for this PR - left a small question in the code. Additionally:
-
In this repo we try our best to keep everything new tested - so would you be open to adding a test for that scenario - there is a
discriminated-union.spec.tsfile where we have a z.enum test that you can use as a base. -
Your build is failing - you have a typescript error.
| @@ -727,6 +727,13 @@ export class OpenAPIGenerator { | |||
| return; | |||
| } | |||
|
|
|||
| if (isZodType(value, 'ZodNativeEnum')) { | |||
| Object.values(value._def.values).forEach((enumValue: string) => { | |||
There was a problem hiding this comment.
Why do we need Object.values here as opposed to the direct usage of value._def.values above?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently discriminating on a field, which changes between different NativeEnum types causes model definition to be incorrect as mapping from discriminator field doesn't map to each of the enum values.
I used the same solution that existed for ZodEnum, and applied it for ZodNativeEnum