Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Solved for authentication #7

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Solved for authentication #7

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions auth.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,13 @@ def read_pwdb():
def add_user(user, password, pwdb):
if user not in pwdb:
pwdb[user] = password

elif user in pwdb:
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
elif user in pwdb:
else:

should be sufficient, since user in pwdb should always be true if user not in pwdb is false, right?

if password == pwdb[user]:
print("Successfully aunthenticated!")
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
print("Successfully aunthenticated!")
print("Successfully authenticated!")

if password != pwdb[user]:
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
if password != pwdb[user]:
else:

same effect, but more readable and safe

print("Wrong password!")

return pwdb


Expand Down