Implemented authenticate_user function #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakobj
requested changes
Jun 26, 2023
There was a problem hiding this comment.
awesome, thank you for your contribution! 🎉
i'm just wondering about the organization of the code: you seem to have moved all functionality into the authenticate function. wouldn't it be nicer to keep the code modular, and stick to the api suggested here?
|
Sure, we'll rewrite it to keep the modular structure of the API. Thanks for your comment! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
We've just implemented the
authenticate_userfunction that checks if the user is in the database and if the provided password is correct.Hope you can take a look at it 👾
Thanks!