Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Update JSInterop details to use direct code evaluation #232

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

peterblazejewicz
Copy link

As mentioned in the comment in the protectedBrowserStorage.js (being
removed), that is now possible to access some native features of the
JavaScript engine without a need of the custom wrapper:

// We may be able to eliminate this .js file entirely as of preview 8,
// because it will be possible to invoke things like localStorage.setValue
// directly from .NET without needing a JS wrapper

This change
removes such access wrapper and simplifies implemenation, which results
in cleaner, quicker to grasp code.

  • implemenation detail changes
  • removed JavaScript code
  • tests updates
  • no JavaScript (Blazor only)
    Thanks!

As mentioned in the comment in the `protectedBrowserStorage.js` (being
removed), that is now possible to access some native features of the
JavaScript engine without a need of the custom wrapper. This change
removes such access wrapper and simplifies implemenation, which results
in cleaner, quicker to grasp code.

- implemenation detail changes
- removed JavaScript code
- tests updates

Thanks!
Base automatically changed from master to main March 11, 2021 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant