Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating the Apple Sign in docs. Undocumented needed setting. #826

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

fgauna12
Copy link

Updated the docs in the Apple ID sign in.

I was getting an exception that ClientSecret was required.

After diving through the code, I found the hack that bypasses the need for ClientSecret when using a Key.

GenerateClientSecret defaults to false.

Added missing boolean in the configuration
@martincostello
Copy link
Member

Thanks for the changes.

It might make more sense to put the setting next to setting the key like in this code here so it's clearer they're related.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants